[Codex] fix(security): sanitize SVG icons before ValueDisplay injection#556
Open
Micsi wants to merge 2 commits into
Open
[Codex] fix(security): sanitize SVG icons before ValueDisplay injection#556Micsi wants to merge 2 commits into
Micsi wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
v-html, creating a stored XSS sink when the icons API returns raw uploaded SVG.v-html.Description
normalizeSvgapproach with asanitizeSvgimplementation infrontend/src/composables/useIcons.tsthat parses the SVG viaDOMParserand returns a cleaned root SVG string.script,foreignObject), strips inline event-handler attributes (on*), and removesjavascript:payloads fromhref/xlink:hrefattributes.width/heightattributes to preserve the original CSS-controlled sizing behavior, and the icon cache now stores sanitized output viasvgCache[icon.name] = sanitizeSvg(icon.content).v-htmlusage.Testing
npm --prefix frontend run typecheck(which runsvue-tsc --noEmit) and it completed successfully.Codex Task